[libcamera-devel] [PATCH 00/10] libcamera: Fixes found while working on new buffer API

[Kieran Bingham]

Hi Niklas,

On 28/10/2019 02:22, Niklas Söderlund wrote:
> Hi,
> 
> This series is a random collection of small fixes I encountered while 
> working on the new buffer API. They could hopefully be merged without 
> much controversy opposed to the real buffer API change.

Indeed, these look good.

I see a few minor comments (well, and an important HAL fixup) from
Jacopo, but I can't find any other faults in there, so for the series:

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>



> Niklas Söderlund (10):
>   libcamera: buffer: Drop forward declaration of BufferPool
>   libcamera: buffer: Plane: Drop friend statement
>   libcamera: buffer: Drop friend statment
>   libcamera: camera: Remove explicit stream to buffer map in
>     requestCompleted signal
>   cam: BufferWriter: Use the libcamera namespace
>   libcamera: v4l2_videodevice: Simplify error checking for
>     requestBuffers()
>   libcamera: pipeline_handler: Do not use argument as local variable
>   libcamera: pipelines: Align where to call base class queueRequest()
>   cam: Store camera as shared pointer everywhere
>   libcamera: pipeline: Drop forward declaration of BufferPool
> 
>  include/libcamera/buffer.h               |  4 ---
>  include/libcamera/camera.h               |  2 +-
>  src/cam/buffer_writer.cpp                |  8 +++---
>  src/cam/capture.cpp                      |  6 +++--
>  src/cam/capture.h                        |  7 +++---
>  src/cam/main.cpp                         |  2 +-
>  src/libcamera/camera.cpp                 |  2 +-
>  src/libcamera/include/pipeline_handler.h |  1 -
>  src/libcamera/pipeline/ipu3/ipu3.cpp     |  5 ++--
>  src/libcamera/pipeline/rkisp1/rkisp1.cpp |  4 +--
>  src/libcamera/pipeline/uvcvideo.cpp      |  4 +--
>  src/libcamera/pipeline/vimc.cpp          |  4 +--
>  src/libcamera/pipeline_handler.cpp       |  8 +++---
>  src/libcamera/v4l2_videodevice.cpp       | 31 ++++++++----------------
>  src/qcam/main_window.cpp                 |  5 ++--
>  src/qcam/main_window.h                   |  3 +--
>  test/camera/capture.cpp                  |  4 ++-
>  17 files changed, 42 insertions(+), 58 deletions(-)
> 

-- 
Regards
--
Kieran