[libcamera-devel] [PATCH 3/3] test: process: Extend timeout duration

Kieran Bingham kieran.bingham at ideasonboard.com
Tue Sep 10 11:04:18 CEST 2019


The process test runs for just 100mS. The spawned process runs for at
least 50mS. Ordinarily this should allow plenty of time for both the
process to be spawned and run, but when adding extra debug
instrumentation, the processes can be slowed down, leading to a false
negative test failure.

Extend the timeout to 2 seconds to allow the short process to be run
correctly - but use the now initialised exitStatus_ to exit the event
loop as soon as the process has completed.

Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
---
 test/process/process_test.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/test/process/process_test.cpp b/test/process/process_test.cpp
index f3cabe0a36c7..7e7b3c2c8bf3 100644
--- a/test/process/process_test.cpp
+++ b/test/process/process_test.cpp
@@ -56,8 +56,8 @@ protected:
 			return TestFail;
 		}
 
-		timeout.start(100);
-		while (timeout.isRunning())
+		timeout.start(2000);
+		while (timeout.isRunning() && exitStatus_ == Process::NotExited)
 			dispatcher->processEvents();
 
 		if (exitStatus_ != Process::NormalExit) {
-- 
2.20.1



More information about the libcamera-devel mailing list