[libcamera-devel] [PATCH 2/3] test: process: Initialise member variables

Laurent Pinchart laurent.pinchart at ideasonboard.com
Tue Sep 10 11:44:18 CEST 2019


Hi Kieran,

Thank you for the patch.

On Tue, Sep 10, 2019 at 10:04:17AM +0100, Kieran Bingham wrote:
> The ProcessTest() declares member variables but leaves them unitialised.
> Set them appropriately from the constructor.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  test/process/process_test.cpp | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/test/process/process_test.cpp b/test/process/process_test.cpp
> index 701f156b5053..f3cabe0a36c7 100644
> --- a/test/process/process_test.cpp
> +++ b/test/process/process_test.cpp
> @@ -35,6 +35,7 @@ class ProcessTest : public Test
>  {
>  public:
>  	ProcessTest()
> +		: exitStatus_(Process::NotExited), exitCode_(-1)
>  	{
>  	}
>  

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list