[libcamera-devel] [PATCH] libcamera: device_enumerator_udev: Align class final declaration with sysfs subclass

[Laurent Pinchart]

Hi Niklas,

Thank you for the patch.

On Mon, Aug 03, 2020 at 12:50:23AM +0200, Niklas Söderlund wrote:
> Instead of marking each individual overloaded function with final mark
> the whole class as final. This aligns the sysfs and udev based
> DeviceEnumerator implementations.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  include/libcamera/internal/device_enumerator_udev.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/libcamera/internal/device_enumerator_udev.h b/include/libcamera/internal/device_enumerator_udev.h
> index 2e7916a0b280f60d..6f45be0c1c423d02 100644
> --- a/include/libcamera/internal/device_enumerator_udev.h
> +++ b/include/libcamera/internal/device_enumerator_udev.h
> @@ -26,14 +26,14 @@ class EventNotifier;
>  class MediaDevice;
>  class MediaEntity;
>  
> -class DeviceEnumeratorUdev : public DeviceEnumerator
> +class DeviceEnumeratorUdev final : public DeviceEnumerator
>  {
>  public:
>  	DeviceEnumeratorUdev();
>  	~DeviceEnumeratorUdev();
>  
> -	int init() final;
> -	int enumerate() final;
> +	int init();
> +	int enumerate();
>  
>  private:
>  	using DependencyMap = std::map<dev_t, std::list<MediaEntity *>>;

-- 
Regards,

Laurent Pinchart