[libcamera-devel] [PATCH] libcamera: device_enumerator_udev: Align class final declaration with sysfs subclass

[Umang Jain]

Hi Niklas,

On 8/3/20 4:20 AM, Niklas Söderlund wrote:
> Instead of marking each individual overloaded function with final mark
> the whole class as final. This aligns the sysfs and udev based
> DeviceEnumerator implementations.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>
Reviewed-by: Umang Jain <email at uajain.com>

Thanks.

> ---
>   include/libcamera/internal/device_enumerator_udev.h | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/libcamera/internal/device_enumerator_udev.h b/include/libcamera/internal/device_enumerator_udev.h
> index 2e7916a0b280f60d..6f45be0c1c423d02 100644
> --- a/include/libcamera/internal/device_enumerator_udev.h
> +++ b/include/libcamera/internal/device_enumerator_udev.h
> @@ -26,14 +26,14 @@ class EventNotifier;
>   class MediaDevice;
>   class MediaEntity;
>   
> -class DeviceEnumeratorUdev : public DeviceEnumerator
> +class DeviceEnumeratorUdev final : public DeviceEnumerator
>   {
>   public:
>   	DeviceEnumeratorUdev();
>   	~DeviceEnumeratorUdev();
>   
> -	int init() final;
> -	int enumerate() final;
> +	int init();
> +	int enumerate();
>   
>   private:
>   	using DependencyMap = std::map<dev_t, std::list<MediaEntity *>>;
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20200803/ebaf9c7c/attachment.htm>