[libcamera-devel] [PATCH 1/2] android: camera_hal_manager: Remove unused getStaticMetadata() method

Kieran Bingham kieran.bingham at ideasonboard.com
Tue Aug 4 15:44:22 CEST 2020


Hi Umang,

On 04/08/2020 13:28, Umang Jain wrote:
> The CameraHalManager::getStaticMethod() method isn't used, remove it.
> 
> Signed-off-by: Umang Jain <email at uajain.com>

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> ---
>  src/android/camera_hal_manager.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/src/android/camera_hal_manager.h b/src/android/camera_hal_manager.h
> index 94d8f00..0619037 100644
> --- a/src/android/camera_hal_manager.h
> +++ b/src/android/camera_hal_manager.h
> @@ -31,8 +31,6 @@ public:
>  	int getCameraInfo(unsigned int id, struct camera_info *info);
>  
>  private:
> -	camera_metadata_t *getStaticMetadata(unsigned int id);
> -
>  	libcamera::CameraManager *cameraManager_;
>  
>  	std::vector<std::unique_ptr<CameraDevice>> cameras_;
> 

-- 
Regards
--
Kieran


More information about the libcamera-devel mailing list