[libcamera-devel] [PATCH 1/2] android: camera_hal_manager: Remove unused getStaticMetadata() method

[Jacopo Mondi]

Hi Umang,

On Tue, Aug 04, 2020 at 03:23:56PM +0200, Niklas Söderlund wrote:
> Hi Umang,
>
> Thanks for your work.
>
> On 2020-08-04 12:28:01 +0000, Umang Jain wrote:
> > The CameraHalManager::getStaticMethod() method isn't used, remove it.
> >
> > Signed-off-by: Umang Jain <email at uajain.com>
>
> Reviewed-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>

Sorry, leftover indeed!

Acked-by: Jacopo Mondi <jacopo at jmondi.org>

Thanks
  j

>
> > ---
> >  src/android/camera_hal_manager.h | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/src/android/camera_hal_manager.h b/src/android/camera_hal_manager.h
> > index 94d8f00..0619037 100644
> > --- a/src/android/camera_hal_manager.h
> > +++ b/src/android/camera_hal_manager.h
> > @@ -31,8 +31,6 @@ public:
> >  	int getCameraInfo(unsigned int id, struct camera_info *info);
> >
> >  private:
> > -	camera_metadata_t *getStaticMetadata(unsigned int id);
> > -
> >  	libcamera::CameraManager *cameraManager_;
> >
> >  	std::vector<std::unique_ptr<CameraDevice>> cameras_;
> > --
> > 2.26.2
> >
> > _______________________________________________
> > libcamera-devel mailing list
> > libcamera-devel at lists.libcamera.org
> > https://lists.libcamera.org/listinfo/libcamera-devel
>
> --
> Regards,
> Niklas Söderlund
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel