[libcamera-devel] [PATCH] android: camera_device: Initialize 'id_' field in constructor

Umang Jain email at uajain.com
Wed Aug 5 14:53:49 CEST 2020


A 'id' is passed when a new CameraDevice is constructed in order for
unique identification. Failing to initialize it,  will lead to the
issue of garbage return value via CameraDevice::id().

Signed-off-by: Umang Jain <email at uajain.com>
---
 src/android/camera_device.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp
index c1e5812..55057f9 100644
--- a/src/android/camera_device.cpp
+++ b/src/android/camera_device.cpp
@@ -163,7 +163,7 @@ CameraDevice::Camera3RequestDescriptor::~Camera3RequestDescriptor()
  */
 
 CameraDevice::CameraDevice(unsigned int id, const std::shared_ptr<Camera> &camera)
-	: running_(false), camera_(camera), staticMetadata_(nullptr),
+	: id_(id), running_(false), camera_(camera), staticMetadata_(nullptr),
 	  facing_(CAMERA_FACING_FRONT), orientation_(0)
 {
 	camera_->requestCompleted.connect(this, &CameraDevice::requestComplete);
-- 
2.26.2



More information about the libcamera-devel mailing list