[libcamera-devel] [PATCH] android: camera_device: Initialize 'id_' field in constructor

[Laurent Pinchart]

Hi Umang,

Thank you for the patch.

On Wed, Aug 05, 2020 at 12:53:49PM +0000, Umang Jain wrote:
> A 'id' is passed when a new CameraDevice is constructed in order for
> unique identification. Failing to initialize it,  will lead to the
> issue of garbage return value via CameraDevice::id().
> 
> Signed-off-by: Umang Jain <email at uajain.com>

Good catch.

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/android/camera_device.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp
> index c1e5812..55057f9 100644
> --- a/src/android/camera_device.cpp
> +++ b/src/android/camera_device.cpp
> @@ -163,7 +163,7 @@ CameraDevice::Camera3RequestDescriptor::~Camera3RequestDescriptor()
>   */
>  
>  CameraDevice::CameraDevice(unsigned int id, const std::shared_ptr<Camera> &camera)
> -	: running_(false), camera_(camera), staticMetadata_(nullptr),
> +	: id_(id), running_(false), camera_(camera), staticMetadata_(nullptr),
>  	  facing_(CAMERA_FACING_FRONT), orientation_(0)
>  {
>  	camera_->requestCompleted.connect(this, &CameraDevice::requestComplete);

-- 
Regards,

Laurent Pinchart