[libcamera-devel] [PATCH v9 2/3] libcamera: raspberrypi: Add control of sensor vblanking

[Naushir Patuck]

On Thu, 17 Dec 2020 at 16:38, Jacopo Mondi <jacopo at jmondi.org> wrote:

> Hi Naush
>
> On Thu, Dec 17, 2020 at 04:35:27PM +0000, Naushir Patuck wrote:
> > Hi Jacopo,
> >
> > >
> > > To be honest, my preference of having FrameDuration returned
> > > unconditionally is only because ExposureTime has a relationship with
> > > the AEG routine being enabled or not. That's a weak preference though,
> > > and if you have other reasons to go in one direction or another I've no
> > > strong preference.
> > >
> >
> > I've viewed ExposureTime and AnalogueGain as intrinsic properties of a
> > frame, regardless of whether manual values were used or not.  Hence why I
> > was setting it every frame.  Of course, the exact same thing could be
> said
> > for Frame Duration!  Perhaps go with what we currently do, and if Laurent
> > and others have a strong preference the other way, I can make the
> necessary
> > updates?
>
> That works for me!
>

Ok great.  I will modify the wording for the control documentation to
reflect what it is (i.e. requested frame limits clipped to what the sensor
mode can achieve), and post a v10 shortly.  I will remove your tag from
patch 1/3 so you can comment if you are happy (or not) with the new
wording.  We will get there eventually! :)

Regards,
Naush


> Thanks
>    j
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20201217/83b24b4b/attachment-0001.htm>