[libcamera-devel] [PATCH] libcamera: request: Add log point on a completed request

[Laurent Pinchart]

Hi Naush,

Thank you for the patch.

On Fri, Jul 24, 2020 at 12:29:50PM +0100, Naushir Patuck wrote:
> Add a debug log point to indicate a request has completed.
> 
> Signed-off-by: Naushir Patuck <naush at raspberrypi.com>
> ---
>  src/libcamera/request.cpp | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp
> index 6b9e0b4a..bcb0a1a7 100644
> --- a/src/libcamera/request.cpp
> +++ b/src/libcamera/request.cpp
> @@ -212,6 +212,10 @@ void Request::complete()
>  {
>  	ASSERT(!hasPendingBuffers());
>  	status_ = cancelled_ ? RequestCancelled : RequestComplete;
> +
> +	LOG(Request, Debug) << "Request has completed - cookie: "
> +			    << cookie_
> +			    << (cancelled_ ? " [Cancelled]" : "");

To avoid pushing the lines towards the right, you can write this

	LOG(Request, Debug)
		<< "Request has completed - cookie: " << cookie_
		<< (cancelled_ ? " [Cancelled]" : "");

We customarily use that style through the code base.

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

No need to resubmit. I'll give a couple of days to others to review the
patch and will then merge it as it has no dependency on the rest of the
series.

>  }
>  
>  /**

-- 
Regards,

Laurent Pinchart