[libcamera-devel] [PATCH] libcamera: request: Add log point on a completed request

[Kieran Bingham]

Hi Naush,

On 24/07/2020 12:29, Naushir Patuck wrote:
> Add a debug log point to indicate a request has completed.
> 
> Signed-off-by: Naushir Patuck <naush at raspberrypi.com>


Thanks, and looks good to me, I think it's useful to have as a common
path to show the completion points..

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> ---
>  src/libcamera/request.cpp | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp
> index 6b9e0b4a..bcb0a1a7 100644
> --- a/src/libcamera/request.cpp
> +++ b/src/libcamera/request.cpp
> @@ -212,6 +212,10 @@ void Request::complete()
>  {
>  	ASSERT(!hasPendingBuffers());
>  	status_ = cancelled_ ? RequestCancelled : RequestComplete;
> +
> +	LOG(Request, Debug) << "Request has completed - cookie: "
> +			    << cookie_
> +			    << (cancelled_ ? " [Cancelled]" : "");
>  }
>  
>  /**
> 

-- 
Regards
--
Kieran