[libcamera-devel] [PATCH 0/3] libcamera sharpness strength control

David Plowman david.plowman at raspberrypi.com
Fri Jun 19 11:27:22 CEST 2020


Hi

Here is a set of patches to implement a sharpness strength control for
libcamera. Unfortunately I couldn't quite bring myself to do it as an
int32_t control because it seems so similar to existing float controls
like contrast, or saturation. But if we'd rather go back to ints, as
previously suggested, just let me know and I'll redo the changes!

There are 3 small patches in this set:

1. The first one just adds the "sharpness" control. This commit is
the only Raspberry Pi indpendent change (and doesn't even involve
any C++ code).

2. The second implements the control's effect in Raspberry Pi's
sharpness control algorithm.

3. The final patch just plumbs the two together.

Thanks and best regards
David

David Plowman (3):
  libcamera: add a sharpness strength control
  libcamera: raspberrypi: add sharpness strength control to Raspberry Pi
    IPAs
  libcamera: raspberrypi: plumb the libcamera sharpness control through
    to the Raspberry Pi implementation

 include/libcamera/ipa/raspberrypi.h           |  1 +
 .../raspberrypi/controller/rpi/sharpen.cpp    | 23 +++++++++++++++----
 .../raspberrypi/controller/rpi/sharpen.hpp    |  6 +++--
 .../controller/sharpen_algorithm.hpp          | 21 +++++++++++++++++
 .../raspberrypi/controller/sharpen_status.h   |  2 ++
 src/ipa/raspberrypi/raspberrypi.cpp           | 12 ++++++++++
 src/libcamera/control_ids.yaml                | 11 +++++++++
 7 files changed, 70 insertions(+), 6 deletions(-)
 create mode 100644 src/ipa/raspberrypi/controller/sharpen_algorithm.hpp

-- 
2.20.1



More information about the libcamera-devel mailing list