[libcamera-devel] [PATCH v4 22/37] libcamera: IPAManager: add isolation flag to proxy creation

Jacopo Mondi jacopo at jmondi.org
Wed Nov 18 14:12:04 CET 2020


Hi Paul,

On Fri, Nov 06, 2020 at 07:36:52PM +0900, Paul Elder wrote:
> When the IPA proxy is created, it needs to know whether to isolate or
> not. Feed the flag at creation of the IPA proxy.
>
> Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>
>

Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>

Thanks
  j

> ---
> No change in v4
>
> No change in v3
>
> No change in v2
> ---
>  src/libcamera/ipa_manager.cpp | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp
> index 12cf3b0d..3a32573f 100644
> --- a/src/libcamera/ipa_manager.cpp
> +++ b/src/libcamera/ipa_manager.cpp
> @@ -291,7 +291,8 @@ std::unique_ptr<IPAProxy> IPAManager::createIPA(PipelineHandler *pipe,
>  		return nullptr;
>  	}
>
> -	std::unique_ptr<IPAProxy> proxy = pf->create(m);
> +	std::unique_ptr<IPAProxy> proxy =
> +		pf->create(m, !self_->isSignatureValid(m));
>  	if (!proxy->isValid()) {
>  		LOG(IPAManager, Error) << "Failed to load proxy";
>  		return nullptr;
> --
> 2.27.0
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel


More information about the libcamera-devel mailing list