[libcamera-devel] [PATCH v4 22/37] libcamera: IPAManager: add isolation flag to proxy creation

[Laurent Pinchart]

Hi Paul,

Thank you for the patch.

On Fri, Nov 06, 2020 at 07:36:52PM +0900, Paul Elder wrote:
> When the IPA proxy is created, it needs to know whether to isolate or
> not. Feed the flag at creation of the IPA proxy.
> 
> Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

But you should really squash this with the patch that adds the flag to
the create function.

> ---
> No change in v4
> 
> No change in v3
> 
> No change in v2
> ---
>  src/libcamera/ipa_manager.cpp | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp
> index 12cf3b0d..3a32573f 100644
> --- a/src/libcamera/ipa_manager.cpp
> +++ b/src/libcamera/ipa_manager.cpp
> @@ -291,7 +291,8 @@ std::unique_ptr<IPAProxy> IPAManager::createIPA(PipelineHandler *pipe,
>  		return nullptr;
>  	}
>  
> -	std::unique_ptr<IPAProxy> proxy = pf->create(m);
> +	std::unique_ptr<IPAProxy> proxy =
> +		pf->create(m, !self_->isSignatureValid(m));
>  	if (!proxy->isValid()) {
>  		LOG(IPAManager, Error) << "Failed to load proxy";
>  		return nullptr;

-- 
Regards,

Laurent Pinchart