[libcamera-devel] [PATCH v3 3/4] src: ipa: raspberrypi: Improve behaviour when AE disabled

[Naushir Patuck]

Hi David,

Thank you for the patch.

On Thu, 26 Nov 2020 at 14:23, David Plowman <david.plowman at raspberrypi.com>
wrote:

> AE/AGC "disabled" is now handled better by the algorithm for itself,
> so it no longer needs to be "resumed" before setting fixed shutter or
> gain values.
>
> Signed-off-by: David Plowman <david.plowman at raspberrypi.com>
>

Reviewed-by Naushir Patuck <naush at raspberrypi.com>


> ---
>  src/ipa/raspberrypi/raspberrypi.cpp | 8 --------
>  1 file changed, 8 deletions(-)
>
> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp
> b/src/ipa/raspberrypi/raspberrypi.cpp
> index 9853a343..29d48b1b 100644
> --- a/src/ipa/raspberrypi/raspberrypi.cpp
> +++ b/src/ipa/raspberrypi/raspberrypi.cpp
> @@ -512,10 +512,6 @@ void IPARPi::queueRequest(const ControlList &controls)
>                         /* This expects units of micro-seconds. */
>                         agc->SetFixedShutter(ctrl.second.get<int32_t>());
>
> -                       /* For the manual values to take effect, AGC must
> be unpaused. */
> -                       if (agc->IsPaused())
> -                               agc->Resume();
> -
>                         libcameraMetadata_.set(controls::ExposureTime,
> ctrl.second.get<int32_t>());
>                         break;
>                 }
> @@ -526,10 +522,6 @@ void IPARPi::queueRequest(const ControlList &controls)
>                         ASSERT(agc);
>
> agc->SetFixedAnalogueGain(ctrl.second.get<float>());
>
> -                       /* For the manual values to take effect, AGC must
> be unpaused. */
> -                       if (agc->IsPaused())
> -                               agc->Resume();
> -
>                         libcameraMetadata_.set(controls::AnalogueGain,
>                                                ctrl.second.get<float>());
>                         break;
> --
> 2.20.1
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20201126/6b9d7a34/attachment.htm>