[libcamera-devel] [PATCH v2 10/11] android: metadata: Disable -Wshadow

Niklas Söderlund niklas.soderlund at ragnatech.se
Fri Oct 16 01:24:20 CEST 2020


Hi Kieran,

On 2020-10-15 23:37:49 +0100, Kieran Bingham wrote:
> Do not warn on shadowed variables inside the metadata library,
> which is directly imported without modifications.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

Neat solution :-)

Reviewed-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>

> ---
>  src/android/meson.build | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/android/meson.build b/src/android/meson.build
> index b2b2293cf62d..2103745dd822 100644
> --- a/src/android/meson.build
> +++ b/src/android/meson.build
> @@ -32,4 +32,5 @@ android_camera_metadata_sources = files([
>  
>  android_camera_metadata = static_library('camera_metadata',
>                                           android_camera_metadata_sources,
> +                                         cpp_args : '-Wnoshadow',
>                                           include_directories : android_includes)
> -- 
> 2.25.1
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

-- 
Regards,
Niklas Söderlund


More information about the libcamera-devel mailing list