[libcamera-devel] [PATCH v2 10/11] android: metadata: Disable -Wshadow

[Laurent Pinchart]

Hi Kieran,

Thank you for the patch.

On Thu, Oct 15, 2020 at 11:37:49PM +0100, Kieran Bingham wrote:
> Do not warn on shadowed variables inside the metadata library,
> which is directly imported without modifications.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

That's better than removing the shadowing I think.

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/android/meson.build | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/android/meson.build b/src/android/meson.build
> index b2b2293cf62d..2103745dd822 100644
> --- a/src/android/meson.build
> +++ b/src/android/meson.build
> @@ -32,4 +32,5 @@ android_camera_metadata_sources = files([
>  
>  android_camera_metadata = static_library('camera_metadata',
>                                           android_camera_metadata_sources,
> +                                         cpp_args : '-Wnoshadow',
>                                           include_directories : android_includes)

-- 
Regards,

Laurent Pinchart