[libcamera-devel] [PATCH] libcamera: pipeline: simple: Remove non-implemented methods

[Kieran Bingham]

Hi Jacopo,

On 21/10/2020 11:33, Jacopo Mondi wrote:
> The initLinks() and createCamera() methods are declared but never
> defined. Remove them.

Well that makes it clear where the simple pipeline handler derived from ;-)


> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>

Indeed, they are not there.

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> ---
>  src/libcamera/pipeline/simple/simple.cpp | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp
> index 8c00c0ffc121..95a2d0bdfaba 100644
> --- a/src/libcamera/pipeline/simple/simple.cpp
> +++ b/src/libcamera/pipeline/simple/simple.cpp
> @@ -145,10 +145,6 @@ private:
>  			PipelineHandler::cameraData(camera));
>  	}
>  
> -	int initLinks();
> -
> -	int createCamera(MediaEntity *sensor);
> -
>  	void bufferReady(FrameBuffer *buffer);
>  	void converterDone(FrameBuffer *input, FrameBuffer *output);
>  
> 

-- 
Regards
--
Kieran