[libcamera-devel] [PATCH] libcamera: pipeline: simple: Remove non-implemented methods

[Niklas Söderlund]

Hi Jacopo,

Thanks for your work.

On 2020-10-21 12:33:52 +0200, Jacopo Mondi wrote:
> The initLinks() and createCamera() methods are declared but never
> defined. Remove them.
> 
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>

Reviewed-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>

> ---
>  src/libcamera/pipeline/simple/simple.cpp | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp
> index 8c00c0ffc121..95a2d0bdfaba 100644
> --- a/src/libcamera/pipeline/simple/simple.cpp
> +++ b/src/libcamera/pipeline/simple/simple.cpp
> @@ -145,10 +145,6 @@ private:
>  			PipelineHandler::cameraData(camera));
>  	}
>  
> -	int initLinks();
> -
> -	int createCamera(MediaEntity *sensor);
> -
>  	void bufferReady(FrameBuffer *buffer);
>  	void converterDone(FrameBuffer *input, FrameBuffer *output);
>  
> -- 
> 2.28.0
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

-- 
Regards,
Niklas Söderlund