[libcamera-devel] [PATCH] libcamera: pipeline: simple: Remove non-implemented methods

Laurent Pinchart laurent.pinchart at ideasonboard.com
Wed Oct 21 20:53:41 CEST 2020


Hi Jacopo,

Thank you for the patch.

On Wed, Oct 21, 2020 at 12:33:52PM +0200, Jacopo Mondi wrote:
> The initLinks() and createCamera() methods are declared but never
> defined. Remove them.
> 
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/libcamera/pipeline/simple/simple.cpp | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp
> index 8c00c0ffc121..95a2d0bdfaba 100644
> --- a/src/libcamera/pipeline/simple/simple.cpp
> +++ b/src/libcamera/pipeline/simple/simple.cpp
> @@ -145,10 +145,6 @@ private:
>  			PipelineHandler::cameraData(camera));
>  	}
>  
> -	int initLinks();
> -
> -	int createCamera(MediaEntity *sensor);
> -
>  	void bufferReady(FrameBuffer *buffer);
>  	void converterDone(FrameBuffer *input, FrameBuffer *output);
>  

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list