[libcamera-devel] [PATCH 0/3] libcamera: Miscellaneous constructors and destructors cleanups

Laurent Pinchart laurent.pinchart at ideasonboard.com
Fri Oct 23 07:10:18 CEST 2020


Hello,

While reviewing Kieran's copy/move disabling series ("[libcamera-devel]
[PATCH 0/5] Delete Copy-Move-Assign"), I noticed a few minor issues in
several classes the needlessly define custom empty default constructors
and destructors. This patch series fixes it.

Laurent Pinchart (3):
  libcamera: media_object: Remove unneeded destructors
  libcamera: Drop unneeded empty default constructors and destructors
  libcamera: Declare empty virtual destructors as defaulted

 include/libcamera/bound_method.h               |  4 ++--
 include/libcamera/internal/control_validator.h |  2 +-
 include/libcamera/internal/ipa_proxy.h         |  2 +-
 include/libcamera/internal/media_object.h      |  5 +----
 include/libcamera/internal/pipeline_handler.h  |  4 ++--
 include/libcamera/ipa/ipa_interface.h          |  2 +-
 include/libcamera/signal.h                     |  1 -
 src/android/jpeg/encoder.h                     |  2 +-
 src/android/post_processor.h                   |  2 +-
 src/cam/options.h                              |  2 +-
 src/libcamera/media_object.cpp                 | 18 ------------------
 src/libcamera/pipeline/rkisp1/timeline.h       |  4 ++--
 src/qcam/viewfinder.h                          |  2 +-
 test/media_device/media_device_print_test.cpp  |  4 ----
 14 files changed, 14 insertions(+), 40 deletions(-)

-- 
Regards,

Laurent Pinchart



More information about the libcamera-devel mailing list