[libcamera-devel] [PATCH v3 14/16] cam: Add option to print the Request metadata

[Hirokazu Honda]

Hi Jacopo, thank you for the patch.

On Thu, Apr 22, 2021 at 3:49 AM Niklas Söderlund
<niklas.soderlund at ragnatech.se> wrote:
>
> Hi Jacopo,
>
> Thanks for your patch.
>
> On 2021-04-21 18:03:17 +0200, Jacopo Mondi wrote:
> > Add the "--metadata" option to the cam tool, which will be used to
> > print the metadata associated with a completed capture request.
> >
> > Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
>
> Reviewed-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>
>

Reviewed-by: Hirokazu Honda <hiroh at chromium.org>

> > ---
> >  src/cam/main.cpp | 3 +++
> >  src/cam/main.h   | 1 +
> >  2 files changed, 4 insertions(+)
> >
> > diff --git a/src/cam/main.cpp b/src/cam/main.cpp
> > index 994fbb343029..687142d8b1a8 100644
> > --- a/src/cam/main.cpp
> > +++ b/src/cam/main.cpp
> > @@ -197,6 +197,9 @@ int CamApp::parseOptions(int argc, char *argv[])
> >       parser.addOption(OptStrictFormats, OptionNone,
> >                        "Do not allow requested stream format(s) to be adjusted",
> >                        "strict-formats");
> > +     parser.addOption(OptMetadata, OptionNone,
> > +                      "Print the list of metadata associated with each completed capture request",
> > +                      "metadata");
> >
> >       options_ = parser.parse(argc, argv);
> >       if (!options_.valid())
> > diff --git a/src/cam/main.h b/src/cam/main.h
> > index ea8dfd330830..d22451f59817 100644
> > --- a/src/cam/main.h
> > +++ b/src/cam/main.h
> > @@ -19,6 +19,7 @@ enum {
> >       OptStream = 's',
> >       OptListControls = 256,
> >       OptStrictFormats = 257,
> > +     OptMetadata = 258,
> >  };
> >
> >  #endif /* __CAM_MAIN_H__ */
> > --
> > 2.31.1
> >
> > _______________________________________________
> > libcamera-devel mailing list
> > libcamera-devel at lists.libcamera.org
> > https://lists.libcamera.org/listinfo/libcamera-devel
>
> --
> Regards,
> Niklas Söderlund
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel