[libcamera-devel] [PATCH v3 14/16] cam: Add option to print the Request metadata

[Laurent Pinchart]

Hi Jacopo,

Thank you for the patch.

On Wed, Apr 21, 2021 at 06:03:17PM +0200, Jacopo Mondi wrote:
> Add the "--metadata" option to the cam tool, which will be used to
> print the metadata associated with a completed capture request.
> 
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
> ---
>  src/cam/main.cpp | 3 +++
>  src/cam/main.h   | 1 +
>  2 files changed, 4 insertions(+)
> 
> diff --git a/src/cam/main.cpp b/src/cam/main.cpp
> index 994fbb343029..687142d8b1a8 100644
> --- a/src/cam/main.cpp
> +++ b/src/cam/main.cpp
> @@ -197,6 +197,9 @@ int CamApp::parseOptions(int argc, char *argv[])
>  	parser.addOption(OptStrictFormats, OptionNone,
>  			 "Do not allow requested stream format(s) to be adjusted",
>  			 "strict-formats");
> +	parser.addOption(OptMetadata, OptionNone,
> +			 "Print the list of metadata associated with each completed capture request",

I would have shortened this a bit to avoid too long lines, maybe to
"Print the metadata for completed requests", but it doesn't matter that
much.

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> +			 "metadata");
>  
>  	options_ = parser.parse(argc, argv);
>  	if (!options_.valid())
> diff --git a/src/cam/main.h b/src/cam/main.h
> index ea8dfd330830..d22451f59817 100644
> --- a/src/cam/main.h
> +++ b/src/cam/main.h
> @@ -19,6 +19,7 @@ enum {
>  	OptStream = 's',
>  	OptListControls = 256,
>  	OptStrictFormats = 257,
> +	OptMetadata = 258,
>  };
>  
>  #endif /* __CAM_MAIN_H__ */

-- 
Regards,

Laurent Pinchart