[libcamera-devel] [PATCH v3 0/3] Fix support for core.mojom structs

Paul Elder paul.elder at ideasonboard.com
Fri Apr 23 12:47:08 CEST 2021


This patch series fixes support for structs defined in core.mojom with
skipHeader only.

Previously these structs were only supported (tested) for use in custom
function parameters, but not as members of other structs. This patch
series fixed that.

In v3, we add a libcamera namespace to core.mojom. This means that
whenever core.mojom structs are used in other mojom files, they need to
be specified with the namespace, eg:

struct A {
	libcamera.ControlList list;
};

Patch 3 makes this change. Patch 2 enables obtaining the proper
namespace of the origin of the struct.

Paul Elder (3):
  utils: ipc: Include instead of forward-declare CameraSensorInfo
  utils: ipc: Use the proper namespace for mojom structs
  ipa: mojom: Put core.mojom in the libcamera namespace

 include/libcamera/ipa/core.mojom              |  5 +--
 include/libcamera/ipa/ipa_interface.h         |  6 ++--
 include/libcamera/ipa/ipu3.mojom              | 11 +++---
 include/libcamera/ipa/raspberrypi.mojom       | 29 ++++++++--------
 include/libcamera/ipa/rkisp1.mojom            | 13 +++----
 include/libcamera/ipa/vimc.mojom              |  2 +-
 .../module_ipa_serializer.h.tmpl              |  2 +-
 .../libcamera_templates/serializer.tmpl       | 34 +++++++++----------
 .../generators/mojom_libcamera_generator.py   | 16 ++++++---
 9 files changed, 65 insertions(+), 53 deletions(-)

-- 
2.27.0



More information about the libcamera-devel mailing list