[libcamera-devel] [IPU3-IPA]PATCH] binary_data: Use type-safe file flags

kieran.bingham at ideasonboard.com kieran.bingham at ideasonboard.com
Wed Aug 4 11:12:56 CEST 2021


Hi Umang,

On 04/08/2021 05:15, Umang Jain wrote:
> In commit 91d06ae2fc61("libcamera: file: Use Flags<> class for open
> flags"), type-safe file mode flags are introduced. Adapt our usage
> accordingly in BinaryData, which uses the File class from libcamera.
> 
> Signed-off-by: Umang Jain <umang.jain at ideasonboard.com>

Ah yes!

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> ---
>  binary_data.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/binary_data.cpp b/binary_data.cpp
> index aa65778..27fc9fe 100644
> --- a/binary_data.cpp
> +++ b/binary_data.cpp
> @@ -37,7 +37,7 @@ int BinaryData::load(const char *filename)
>  		return -ENOENT;
>  	}
>  
> -	if (!binary.open(File::ReadOnly)) {
> +	if (!binary.open(File::OpenModeFlag::ReadOnly)) {
>  		LOG(AIBD, Error) << "Failed to open: " << filename;
>  		return -EINVAL;
>  	}
> 


More information about the libcamera-devel mailing list