[libcamera-devel] [IPU3-IPA]PATCH] binary_data: Use type-safe file flags

[Laurent Pinchart]

Hi Umang,

Thank you for the patch.

On Wed, Aug 04, 2021 at 09:45:19AM +0530, Umang Jain wrote:
> In commit 91d06ae2fc61("libcamera: file: Use Flags<> class for open
> flags"), type-safe file mode flags are introduced. Adapt our usage
> accordingly in BinaryData, which uses the File class from libcamera.
> 
> Signed-off-by: Umang Jain <umang.jain at ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Sorry for not noticing.

> ---
>  binary_data.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/binary_data.cpp b/binary_data.cpp
> index aa65778..27fc9fe 100644
> --- a/binary_data.cpp
> +++ b/binary_data.cpp
> @@ -37,7 +37,7 @@ int BinaryData::load(const char *filename)
>  		return -ENOENT;
>  	}
>  
> -	if (!binary.open(File::ReadOnly)) {
> +	if (!binary.open(File::OpenModeFlag::ReadOnly)) {
>  		LOG(AIBD, Error) << "Failed to open: " << filename;
>  		return -EINVAL;
>  	}

-- 
Regards,

Laurent Pinchart