[libcamera-devel] [PATCH v2] ipa: raspberrypi: Use boolean constructor for AeEnable ControlInfo

Paul Elder paul.elder at ideasonboard.com
Thu Aug 12 06:22:49 CEST 2021


The min-max constructor is not the proper constructor for boolean
ControlInfos. Use the proper boolean constructor.

Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>

---
Changes in v2:
- whoops, sorry v1 was based on Jacopo's "libcamera: Initialize controls
  in the IPA"
---
 include/libcamera/ipa/raspberrypi.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/libcamera/ipa/raspberrypi.h b/include/libcamera/ipa/raspberrypi.h
index a8790000..7ef14e57 100644
--- a/include/libcamera/ipa/raspberrypi.h
+++ b/include/libcamera/ipa/raspberrypi.h
@@ -28,7 +28,7 @@ namespace RPi {
  * unsupported control is encountered.
  */
 static const ControlInfoMap Controls = {
-	{ &controls::AeEnable, ControlInfo(false, true) },
+	{ &controls::AeEnable, ControlInfo({false, true}, true) },
 	{ &controls::ExposureTime, ControlInfo(0, 999999) },
 	{ &controls::AnalogueGain, ControlInfo(1.0f, 32.0f) },
 	{ &controls::AeMeteringMode, ControlInfo(controls::AeMeteringModeValues) },
-- 
2.27.0



More information about the libcamera-devel mailing list