[libcamera-devel] [PATCH] ipa: raspberrypi: Use boolean constructor for AeEnable ControlInfo

[Laurent Pinchart]

Hi Paul,

Thank you for the patch.

On Thu, Aug 12, 2021 at 12:48:18PM +0900, Paul Elder wrote:
> The min-max constructor is not the proper constructor for boolean
> ControlInfos. Use the proper boolean constructor.
> 
> Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>

Just to make sure, have you tested enabling/disabling AE with this patch
applied ? If so,

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  include/libcamera/ipa/raspberrypi.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/libcamera/ipa/raspberrypi.h b/include/libcamera/ipa/raspberrypi.h
> index b82c2cec..6ff9ed7b 100644
> --- a/include/libcamera/ipa/raspberrypi.h
> +++ b/include/libcamera/ipa/raspberrypi.h
> @@ -28,7 +28,7 @@ namespace RPi {
>   * unsupported control is encountered.
>   */
>  static const ControlInfoMap Controls({
> -		{ &controls::AeEnable, ControlInfo(false, true) },
> +		{ &controls::AeEnable, ControlInfo({ false, true }, true) },
>  		{ &controls::ExposureTime, ControlInfo(0, 999999) },
>  		{ &controls::AnalogueGain, ControlInfo(1.0f, 32.0f) },
>  		{ &controls::AeMeteringMode, ControlInfo(controls::AeMeteringModeValues) },

-- 
Regards,

Laurent Pinchart