[libcamera-devel] [SimpleCam PATCH 0/4] Improve CameraManager usage and Doc

[paul.elder at ideasonboard.com]

Hi Kieran,

On Tue, Aug 24, 2021 at 03:24:46PM +0100, Kieran Bingham wrote:
> The CameraManager was not being released before the end of the
> application. While this does not cause any direct issues, it counts as a
> memory leak.
> 
> Demonstrate a cleaner way to manage the CameraManager using a unique_ptr
> to convey that the application is responsible for it's lifetime.
> 
> Along the way, improve the documentation throughout.

Looks good.

Reviewed-by: Paul Elder <paul.elder at ideasonboard.com>

> 
> Kieran Bingham (4):
>   simple-cam: Use a unique_ptr for the CameraManager
>   simple-cam: Improve documentation of validate/configure
>   simple-cam: Fix the Buffer Allocation guidance
>   simple-cam: Correct the capitalisation of 'libcamera'
> 
>  simple-cam.cpp | 37 ++++++++++++++++++++++++++-----------
>  1 file changed, 26 insertions(+), 11 deletions(-)
> 
> -- 
> 2.30.2
>