[libcamera-devel] [SimpleCam PATCH 4/4] simple-cam: Correct the capitalisation of 'libcamera'

Laurent Pinchart laurent.pinchart at ideasonboard.com
Wed Aug 25 22:01:19 CEST 2021


Hi Kieran,

Thank you for the patch.

On Tue, Aug 24, 2021 at 03:24:50PM +0100, Kieran Bingham wrote:
> Even when used at the beginning of a sentence, the 'libcamera' name
> always starts with a lower case 'l'. Fix the incorrect usages of the
> name.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  simple-cam.cpp | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/simple-cam.cpp b/simple-cam.cpp
> index 47c5dc9987bc..7ba423df9089 100644
> --- a/simple-cam.cpp
> +++ b/simple-cam.cpp
> @@ -301,7 +301,7 @@ int main()
>  	 * --------------------------------------------------------------------
>  	 * Frame Capture
>  	 *
> -	 * Libcamera frames capture model is based on the 'Request' concept.
> +	 * libcamera frames capture model is based on the 'Request' concept.
>  	 * For each frame a Request has to be queued to the Camera.
>  	 *
>  	 * A Request refers to (at least one) Stream for which a Buffer that
> @@ -348,7 +348,7 @@ int main()
>  	 * --------------------------------------------------------------------
>  	 * Signal&Slots
>  	 *
> -	 * Libcamera uses a Signal&Slot based system to connect events to
> +	 * libcamera uses a Signal&Slot based system to connect events to
>  	 * callback operations meant to handle them, inspired by the QT graphic
>  	 * toolkit.
>  	 *
> @@ -398,12 +398,13 @@ int main()
>  	int ret = loop.exec();
>  	std::cout << "Capture ran for " << TIMEOUT_SEC << " seconds and "
>  		  << "stopped with exit status: " << ret << std::endl;
> +
>  	/*
>  	 * --------------------------------------------------------------------
>  	 * Clean Up
>  	 *
>  	 * Stop the Camera, release resources and stop the CameraManager.
> -	 * Libcamera has now released all resources it owned.
> +	 * libcamera has now released all resources it owned.
>  	 */
>  	camera->stop();
>  	allocator->free(stream);

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list