[libcamera-devel] [PATCH v3 0/4] ipu3: Change sensor size selection policy

Umang Jain umang.jain at ideasonboard.com
Mon Aug 30 10:21:46 CEST 2021


The series is geared towards addressing sensor selection constraints
on soraka and nautilus. 1/4 and 2/4 prepares the base to highlight
the change in selection policy. 3/4 and 4/4 is the actual change.

The constraints are documented in the commit messages of 3/4 and 4/4.

Changes in v3:
- Minor for loop matching change in 1/4
- Remove author's "Tested-by" tags (mainly were added since I was
  testing CTS rigoursly)
- Descriptive comment on ratio diffs in 4/4
- Few commit typo fixes

Changes in v2:
- 1/4 also sees the change in CIO2Device::sizes to  
  CIO2Device::sizes(pixelFormat).
- Use std::numeric_limits<> in 2/4. Include <math.h> otherwise
  compilation breaks on gcc.
- Few wordings restructure.

Umang Jain (4):
  libcamera: camera_sensor: Transform CameraSensor::sizes()
  ipu3: cio2: Replicate CameraSensor::getFormats() to a member function
  ipu3: cio2: Change sensor size selection policy
  ipu3: cio2: Tweak sensor size selection policy

 include/libcamera/internal/camera_sensor.h |   2 +-
 src/libcamera/camera_sensor.cpp            |  25 ++++-
 src/libcamera/pipeline/ipu3/cio2.cpp       | 125 ++++++++++++++++++++-
 src/libcamera/pipeline/ipu3/cio2.h         |   5 +-
 src/libcamera/pipeline/ipu3/ipu3.cpp       |   2 +-
 test/camera-sensor.cpp                     |   2 +-
 6 files changed, 145 insertions(+), 16 deletions(-)

-- 
2.31.1



More information about the libcamera-devel mailing list