[libcamera-devel] [PATCH 1/2] utils: checkstyle.py: Restore checks of renamed files

[Kieran Bingham]

Hi Laurent,

On 12/02/2021 11:09, Laurent Pinchart wrote:
> Commit fc91951250ca ("utils: checkstyle.py: Add ability to filter files
> by status in a commit") caused all renamed files to be ignored by the
> checker. Fix it.
> 
> Fixes: fc91951250ca ("utils: checkstyle.py: Add ability to filter files by status in a commit")
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Sounds too easy. I thought the rabbit hole would be much deeper than that!

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> ---
>  utils/checkstyle.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/utils/checkstyle.py b/utils/checkstyle.py
> index fb9366f8095d..93a4fc70fafa 100755
> --- a/utils/checkstyle.py
> +++ b/utils/checkstyle.py
> @@ -214,7 +214,7 @@ class Commit:
>          self._files = [CommitFile(f) for f in files[1:]]
>          self._title = files[0]
>  
> -    def files(self, filter='AM'):
> +    def files(self, filter='AMR'):
>          return [f.filename for f in self._files if f.status in filter]
>  
>      @property
> 

-- 
Regards
--
Kieran