[libcamera-devel] [PATCH 2/2] utils: checkstyle.py: Handle renamed files in header add checker

[Kieran Bingham]

On 12/02/2021 11:09, Laurent Pinchart wrote:
> The header add checker only handles added header, which makes it miss
> issues when a header is renamed. Fix it.
> 
> Fixes: 8fffab46b80f ("utils: checkstyle.py: Add header add checker")
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Great, ;-) Now I won't have an excuse for missing this next time.

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> ---
>  utils/checkstyle.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/utils/checkstyle.py b/utils/checkstyle.py
> index 93a4fc70fafa..ececb46eaacc 100755
> --- a/utils/checkstyle.py
> +++ b/utils/checkstyle.py
> @@ -314,7 +314,7 @@ class HeaderAddChecker(CommitChecker):
>          meson_files = [f for f in commit.files('M')
>                         if os.path.basename(f) == 'meson.build']
>  
> -        for filename in commit.files('A'):
> +        for filename in commit.files('AR'):
>              if not filename.startswith('include/libcamera/') or \
>                 not filename.endswith('.h'):
>                  continue
> 

-- 
Regards
--
Kieran