[libcamera-devel] [PATCH v3 3/4] android: camera_device: Default the camera location to Front

[Paul Elder]

Since the libcamera camera now has an Unknown location, we can know if
the camera's location is actually unknown. In this case, set the android
camera location to front, as some systems may not support external
cameras.

This allows the following CTS test to pass:
- android.hardware.camera2.cts.CameraManagerTest#testCameraManagerGetDeviceIdList

Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>

---
Changes in v3:
- print warning when defaulting to front from unknown location

No change in v2
---
 src/android/camera_device.cpp | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp
index 1e2a5b5f..a4447c16 100644
--- a/src/android/camera_device.cpp
+++ b/src/android/camera_device.cpp
@@ -407,6 +407,11 @@ int CameraDevice::initialize()
 		case properties::CameraLocationExternal:
 			facing_ = CAMERA_FACING_EXTERNAL;
 			break;
+		case properties::CameraLocationUnknown:
+			LOG(HAL, Warning)
+				<< "Unknown camera location, defaulting to front";
+			facing_ = CAMERA_FACING_FRONT;
+			break;
 		}
 	}
 
-- 
2.27.0