[libcamera-devel] [PATCH v3 4/4] cam: Print unknown location

Paul Elder paul.elder at ideasonboard.com
Mon Feb 15 11:12:00 CET 2021


Now that we default the camera sensor location to Unknown, print that
the location is unknown in cam. We report the location as unknown
instead of defaulting to something else since cam is a test tool.

Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>

---
Changes in v3:
- report the location as unknown

New in v2
---
 src/cam/main.cpp | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/cam/main.cpp b/src/cam/main.cpp
index e01be63a..14f12e9d 100644
--- a/src/cam/main.cpp
+++ b/src/cam/main.cpp
@@ -379,7 +379,8 @@ std::string const CamApp::cameraName(const Camera *camera)
 	const ControlList &props = camera->properties();
 	std::string name;
 
-	switch (props.get(properties::Location)) {
+	int location = props.get(properties::Location);
+	switch (location) {
 	case properties::CameraLocationFront:
 		name = "Internal front camera";
 		break;
@@ -387,7 +388,10 @@ std::string const CamApp::cameraName(const Camera *camera)
 		name = "Internal back camera";
 		break;
 	case properties::CameraLocationExternal:
-		name = "External camera";
+	case properties::CameraLocationUnknown:
+		name = location == properties::CameraLocationExternal ?
+				   "External camera" :
+				   "Unknown Location";
 		if (props.contains(properties::Model))
 			name += " '" + props.get(properties::Model) + "'";
 		break;
-- 
2.27.0



More information about the libcamera-devel mailing list