[libcamera-devel] [PATCH] libcamera: pipeline: vimc: Fail without an IPA

Kieran Bingham kieran.bingham at ideasonboard.com
Wed Jun 16 11:56:10 CEST 2021


Registering a camera for VIMC without an IPA will fail later when
attempting to configure.

The IPA is required for VIMC so fail early if it can't be loaded.

Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
---
 src/libcamera/pipeline/vimc/vimc.cpp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp
index 9ebd723be171..8af0e92012e6 100644
--- a/src/libcamera/pipeline/vimc/vimc.cpp
+++ b/src/libcamera/pipeline/vimc/vimc.cpp
@@ -431,6 +431,7 @@ bool PipelineHandlerVimc::match(DeviceEnumerator *enumerator)
 		data->ipa_->init(IPASettings{ conf, data->sensor_->model() });
 	} else {
 		LOG(VIMC, Warning) << "no matching IPA found";
+		return false;
 	}
 
 	/* Create and register the camera. */
-- 
2.30.2



More information about the libcamera-devel mailing list