[libcamera-devel] [PATCH] android: mm: cros_camera_buffer: Fix wrong indexing in plane()

[paul.elder at ideasonboard.com]

Hi Hiro,

Sorry for the delay.

On Wed, Jun 16, 2021 at 05:59:23PM +0900, Hirokazu Honda wrote:
> CameraBuffer::plane() should be accessed in zero based index.
> Fix the wrong indexing in CameraBuffer::plane() in
> cros_camera_buffer.cpp.
> 
> Signed-off-by: Hirokazu Honda <hiroh at chromium.org>

Reviewed-by: Paul Elder <paul.elder at ideasonboard.com>

> ---
>  src/android/mm/cros_camera_buffer.cpp | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/android/mm/cros_camera_buffer.cpp b/src/android/mm/cros_camera_buffer.cpp
> index 59e26d1b..c4157606 100644
> --- a/src/android/mm/cros_camera_buffer.cpp
> +++ b/src/android/mm/cros_camera_buffer.cpp
> @@ -113,13 +113,13 @@ Span<uint8_t> CameraBuffer::Private::plane(unsigned int plane)
>  		break;
>  	default:
>  		switch (plane) {
> -		case 1:
> +		case 0:
>  			addr = mem.ycbcr.y;
>  			break;
> -		case 2:
> +		case 1:
>  			addr = mem.ycbcr.cb;
>  			break;
> -		case 3:
> +		case 2:
>  			addr = mem.ycbcr.cr;
>  			break;
>  		}
> -- 
> 2.32.0.272.g935e593368-goog
>