[libcamera-devel] [PATCH] android: mm: cros_camera_buffer: Drop undefined functions

[Hirokazu Honda]

Hi Laurent, thank you for the patch.

On Fri, Jun 25, 2021 at 10:09 PM Laurent Pinchart
<laurent.pinchart at ideasonboard.com> wrote:
>
> The CameraBuffer::Private::planeAddr() functions are declared but not
> defined (and of course not used). Drop them.
>
> Fixes: d8d6a78f223e ("android: Introduce Chromium OS buffer manager")
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Reviewed-by: Hirokazu Honda <hiroh at chromium.org>

> ---
>  src/android/mm/cros_camera_buffer.cpp | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/src/android/mm/cros_camera_buffer.cpp b/src/android/mm/cros_camera_buffer.cpp
> index c4157606d762..317d3e23687f 100644
> --- a/src/android/mm/cros_camera_buffer.cpp
> +++ b/src/android/mm/cros_camera_buffer.cpp
> @@ -42,9 +42,6 @@ private:
>                 void *addr;
>                 android_ycbcr ycbcr;
>         } mem;
> -
> -       const uint8_t *planeAddr(unsigned int plane) const;
> -       uint8_t *planeAddr(unsigned int plane);
>  };
>
>  CameraBuffer::Private::Private(CameraBuffer *cameraBuffer,
> --
> Regards,
>
> Laurent Pinchart
>