[libcamera-devel] [PATCH] android: mm: cros_camera_buffer: Drop undefined functions

Umang Jain umang.jain at ideasonboard.com
Mon Jun 28 06:31:53 CEST 2021


Hi Laurent,

On 6/25/21 6:38 PM, Laurent Pinchart wrote:
> The CameraBuffer::Private::planeAddr() functions are declared but not
> defined (and of course not used). Drop them.
>
> Fixes: d8d6a78f223e ("android: Introduce Chromium OS buffer manager")
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
Reviewed-by: Umang Jain <umang.jain at ideasonboard.com>
> 	
> ---
>   src/android/mm/cros_camera_buffer.cpp | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/src/android/mm/cros_camera_buffer.cpp b/src/android/mm/cros_camera_buffer.cpp
> index c4157606d762..317d3e23687f 100644
> --- a/src/android/mm/cros_camera_buffer.cpp
> +++ b/src/android/mm/cros_camera_buffer.cpp
> @@ -42,9 +42,6 @@ private:
>   		void *addr;
>   		android_ycbcr ycbcr;
>   	} mem;
> -
> -	const uint8_t *planeAddr(unsigned int plane) const;
> -	uint8_t *planeAddr(unsigned int plane);
>   };
>   
>   CameraBuffer::Private::Private(CameraBuffer *cameraBuffer,


More information about the libcamera-devel mailing list