[libcamera-devel] [PATCH v4 0/7] DelayedControls updates and fixes

[Naushir Patuck]

Hi,

Another nudge for some feedback on this patch series.

Regards,
Naush

On Thu, 4 Mar 2021 at 08:17, Naushir Patuck <naush at raspberrypi.com> wrote:

> Hi,
>
> This version (v4) of the patch series adds two further commits to v3.
>
> Patches 1 to 5 are identical to v3, except that I have added a line to the
> commit
> messages saying the change would break the unit tests because of a change
> in the
> logic of the helper.
>
> Patch 6 updates the unit tests with the correct behavior.  Unfortunately,
> my
> attempts to get vimc working on my platform did not end well, so I made a
> local
> mod to run the tests with a physical camera device. All tests do pass, but
> I
> would appreciate if somebody else could run this again with the vimc
> device to
> verify everything is passing.
>
> Patch 7 simply fixes a typo in the unit test filename.
>
> Thanks,
> Naush
>
> Naushir Patuck (7):
>   libcamera: delayed_controls: Add notion of priority write
>   utils: raspberrypi: Add a DelayedControls log parser
>   libcamera: delayed_controls: Remove unneeded write when starting up
>   libcamera: delayed_controls: Remove spurious no-op queued controls
>   libcamera: delayed_controls: Fix off-by-one error in get()
>   test: delayed_controls: Fixup tests after recent DelayedControls
>     changes
>   test: delayed_controls: Rename delayed_contols.cpp to
>     delayed_controls.cpp
>
>  include/libcamera/internal/delayed_controls.h |  13 +-
>  src/libcamera/delayed_controls.cpp            |  74 ++++++++----
>  src/libcamera/pipeline/ipu3/ipu3.cpp          |   8 +-
>  .../pipeline/raspberrypi/raspberrypi.cpp      |  13 +-
>  src/libcamera/pipeline/rkisp1/rkisp1.cpp      |   8 +-
>  ...layed_contols.cpp => delayed_controls.cpp} |  51 +++++---
>  test/meson.build                              |   2 +-
>  utils/raspberrypi/delayedctrls_parse.py       | 111 ++++++++++++++++++
>  8 files changed, 219 insertions(+), 61 deletions(-)
>  rename test/{delayed_contols.cpp => delayed_controls.cpp} (84%)
>  create mode 100644 utils/raspberrypi/delayedctrls_parse.py
>
> --
> 2.25.1
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20210309/c37ee047/attachment.htm>