[libcamera-devel] [PATCH] ipa: ipa_interface: Add comment to defend the forward-declaration
Paul Elder
paul.elder at ideasonboard.com
Mon Mar 15 10:24:56 CET 2021
Any struct that is defined in core.mojom with the skipHeader tag needs
to be present in ipa_interface, either forward-declared or #included.
Add an argument so that, in the future, people don't try to send patches
removing the seemingly unused forward-declaration.
Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
---
include/libcamera/ipa/ipa_interface.h | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h
index 47f81d1d..5d99e2cf 100644
--- a/include/libcamera/ipa/ipa_interface.h
+++ b/include/libcamera/ipa/ipa_interface.h
@@ -20,6 +20,11 @@
namespace libcamera {
+/*
+ * Structs that are defined in core.mojom and have the skipHeader tag must be
+ * forward-declared or #included here.
+ */
+
struct CameraSensorInfo;
class IPAInterface
--
2.27.0
More information about the libcamera-devel
mailing list