[libcamera-devel] [PATCH] ipa: ipa_interface: Add comment to defend the forward-declaration

[Niklas Söderlund]

Hi Paul,

Thanks for your patch.

On 2021-03-15 18:24:56 +0900, Paul Elder wrote:
> Any struct that is defined in core.mojom with the skipHeader tag needs
> to be present in ipa_interface, either forward-declared or #included.
> Add an argument so that, in the future, people don't try to send patches
> removing the seemingly unused forward-declaration.
> 
> Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>

I have commented once that this forward declaration should be dropped 
and acked a patch that removes it, hopefully a comment reminding me to 
not do so will stop me in the future to make the same mistake ;-)

Reviewed-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>

> ---
>  include/libcamera/ipa/ipa_interface.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h
> index 47f81d1d..5d99e2cf 100644
> --- a/include/libcamera/ipa/ipa_interface.h
> +++ b/include/libcamera/ipa/ipa_interface.h
> @@ -20,6 +20,11 @@
>  
>  namespace libcamera {
>  
> +/*
> + * Structs that are defined in core.mojom and have the skipHeader tag must be
> + * forward-declared or #included here.
> + */
> +
>  struct CameraSensorInfo;
>  
>  class IPAInterface
> -- 
> 2.27.0
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

-- 
Regards,
Niklas Söderlund