[libcamera-devel] [PATCH 2/7] libcamera: android: Add libyaml dependency

[Jacopo Mondi]

Hi Hiro,

On Thu, Mar 25, 2021 at 03:27:17PM +0900, Hirokazu Honda wrote:
> Hi Jacopo, thanks for the patch.
>
> On Wed, Mar 24, 2021 at 8:25 PM Jacopo Mondi <jacopo at jmondi.org> wrote:
> >
> > Add a dependency to the libyaml library.
> >
> > The pkg-config symbol is named yaml-0.1
> >
> > Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
> > ---
> >  README.rst              | 2 +-
> >  src/android/meson.build | 1 +
> >  2 files changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/README.rst b/README.rst
> > index 28c33871140a..1a888f86ac64 100644
> > --- a/README.rst
> > +++ b/README.rst
> > @@ -88,7 +88,7 @@ for tracing with lttng: [optional]
> >          liblttng-ust-dev python3-jinja2 lttng-tools
> >
> >  for Android Camera3 HAL: [optional]
> > -        libexif libjpeg
> > +        libexif libjpeg libyaml
> >
> >  Using GStreamer plugin
> >  ~~~~~~~~~~~~~~~~~~~~~~
> > diff --git a/src/android/meson.build b/src/android/meson.build
> > index 87d162c3bbea..19f94a4073f1 100644
> > --- a/src/android/meson.build
> > +++ b/src/android/meson.build
> > @@ -3,6 +3,7 @@
> >  android_deps = [
> >      dependency('libexif', required : get_option('android')),
> >      dependency('libjpeg', required : get_option('android')),
> > +    dependency('yaml-0.1', required : get_option('android')),
> >  ]
>
> Is this necessary to be 'yaml-0.1'?
> Doesn't 'libyaml' work?
>

To have the library correctly located by pkg-config, that's the symbol
to be used in my understanding. libyaml (which was the most obvious
choice to me) didn't work in my native Linux nor ChromiumOS.

So I went and

$ pkg-config --list-all | grep yaml
yaml-0.1                       LibYAML - Library to parse and emit YAML

So it seems that's the symbol name that pkg-config uses for libyaml

> -Hiro
>
> >
> >  android_enabled = true
> > --
> > 2.30.0
> >
> > _______________________________________________
> > libcamera-devel mailing list
> > libcamera-devel at lists.libcamera.org
> > https://lists.libcamera.org/listinfo/libcamera-devel