[libcamera-devel] [PATCH 2/7] libcamera: android: Add libyaml dependency

Laurent Pinchart laurent.pinchart at ideasonboard.com
Fri Mar 26 04:10:53 CET 2021


Hi Jacopo,

Thank you for the patch.

On Wed, Mar 24, 2021 at 12:25:22PM +0100, Jacopo Mondi wrote:
> Add a dependency to the libyaml library.
> 
> The pkg-config symbol is named yaml-0.1
> 
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>

I'd squash this with 4/7, up to you.

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  README.rst              | 2 +-
>  src/android/meson.build | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/README.rst b/README.rst
> index 28c33871140a..1a888f86ac64 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -88,7 +88,7 @@ for tracing with lttng: [optional]
>          liblttng-ust-dev python3-jinja2 lttng-tools
>  
>  for Android Camera3 HAL: [optional]
> -        libexif libjpeg
> +        libexif libjpeg libyaml
>  
>  Using GStreamer plugin
>  ~~~~~~~~~~~~~~~~~~~~~~
> diff --git a/src/android/meson.build b/src/android/meson.build
> index 87d162c3bbea..19f94a4073f1 100644
> --- a/src/android/meson.build
> +++ b/src/android/meson.build
> @@ -3,6 +3,7 @@
>  android_deps = [
>      dependency('libexif', required : get_option('android')),
>      dependency('libjpeg', required : get_option('android')),
> +    dependency('yaml-0.1', required : get_option('android')),
>  ]
>  
>  android_enabled = true

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list