[libcamera-devel] [PATCH] ipa: raspberrypi: Fix typo and improve wording

[Laurent Pinchart]

Hi Sebastian,

Thank you for the patch.

On Sun, Mar 28, 2021 at 07:03:03PM +0200, Sebastian Fricke wrote:
> s/Return the validated limits out though metadata./
>   Return the validated limits via metadata./
> 
> Signed-off-by: Sebastian Fricke <sebastian.fricke at posteo.net>
> ---
> It is probably debatable, if we should remove that comment completely,
> as the code is quite self explanatory. But it might help.

I'll let Naush and David decide what they like best, and they apply the
patch.

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/ipa/raspberrypi/raspberrypi.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp
> index ed2d9a54..dad6395f 100644
> --- a/src/ipa/raspberrypi/raspberrypi.cpp
> +++ b/src/ipa/raspberrypi/raspberrypi.cpp
> @@ -1066,7 +1066,7 @@ void IPARPi::applyFrameDurations(double minFrameDuration, double maxFrameDuratio
>  				       minSensorFrameDuration, maxSensorFrameDuration);
>  	maxFrameDuration_ = std::max(maxFrameDuration_, minFrameDuration_);
>  
> -	/* Return the validated limits out though metadata. */
> +	/* Return the validated limits via metadata. */
>  	libcameraMetadata_.set(controls::FrameDurations,
>  			       { static_cast<int64_t>(minFrameDuration_),
>  				 static_cast<int64_t>(maxFrameDuration_) });

-- 
Regards,

Laurent Pinchart