[libcamera-devel] [PATCH] ipa: raspberrypi: Fix typo and improve wording

[Naushir Patuck]

Hi Sebastian,

Thank you for your patch.

On Sun, 28 Mar 2021 at 18:03, Sebastian Fricke <sebastian.fricke at posteo.net>
wrote:

> s/Return the validated limits out though metadata./
>   Return the validated limits via metadata./
>
> Signed-off-by: Sebastian Fricke <sebastian.fricke at posteo.net>
>
---
> It is probably debatable, if we should remove that comment completely,
> as the code is quite self explanatory. But it might help.
> ---
>

I see no harm in keeping the comment.
Reviewed-by: Naushir Patuck <naush at raspberrypi.com>


>  src/ipa/raspberrypi/raspberrypi.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp
> b/src/ipa/raspberrypi/raspberrypi.cpp
> index ed2d9a54..dad6395f 100644
> --- a/src/ipa/raspberrypi/raspberrypi.cpp
> +++ b/src/ipa/raspberrypi/raspberrypi.cpp
> @@ -1066,7 +1066,7 @@ void IPARPi::applyFrameDurations(double
> minFrameDuration, double maxFrameDuratio
>                                        minSensorFrameDuration,
> maxSensorFrameDuration);
>         maxFrameDuration_ = std::max(maxFrameDuration_, minFrameDuration_);
>
> -       /* Return the validated limits out though metadata. */
> +       /* Return the validated limits via metadata. */
>         libcameraMetadata_.set(controls::FrameDurations,
>                                { static_cast<int64_t>(minFrameDuration_),
>                                  static_cast<int64_t>(maxFrameDuration_)
> });
> --
> 2.25.1
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20210329/d5229e32/attachment-0001.htm>