[libcamera-devel] [PATCH v2 4/7] libcamera: ipu3: imgu: Fix IF height selection

[Hirokazu Honda]

Hi Jacopo, thank you for the patch.

On Mon, May 3, 2021 at 7:56 PM Niklas Söderlund <
niklas.soderlund at ragnatech.se> wrote:

> Hi Jacopo,
>
> Thanks for your work.
>
> On 2021-05-03 11:27:02 +0200, Jacopo Mondi wrote:
> > Apply to calculateBDSHeight() function the first hunk of commit 243d134
> > ("Fix some bug for some resolutions") from
> > https://github.com/intel/intel-ipu3-pipecfg.git.
> >
> > The condition for the computed IF rectangle height to be matched
> > against the desired alignment now makes sure that it is included
> > in the minimum and maximum acceptable values.
> >
> > Tested-by: Jean-Michel Hautbois <jeanmichel.hautbois at ideasonboard.com>
> > Reviewed-by: Jean-Michel Hautbois <jeanmichel.hautbois at ideasonboard.com>
> > Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
>
> Acked-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>
>
>
Reviewed-by: Hirokazu Honda <hiroh at chromium.org>


> > ---
> >  src/libcamera/pipeline/ipu3/imgu.cpp | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp
> b/src/libcamera/pipeline/ipu3/imgu.cpp
> > index ea654e57b0e7..feee2cc55abd 100644
> > --- a/src/libcamera/pipeline/ipu3/imgu.cpp
> > +++ b/src/libcamera/pipeline/ipu3/imgu.cpp
> > @@ -135,7 +135,8 @@ void calculateBDSHeight(ImgUDevice::Pipe *pipe,
> const Size &iif, const Size &gdc
> >               estIFHeight = std::clamp<float>(estIFHeight, minIFHeight,
> iif.height);
> >
> >               ifHeight = utils::alignUp(estIFHeight, IF_ALIGN_H);
> > -             while (ifHeight >= minIFHeight && ifHeight / bdsSF >=
> minBDSHeight) {
> > +             while (ifHeight >= minIFHeight && ifHeight <= iif.height &&
> > +                    ifHeight / bdsSF >= minBDSHeight) {
> >
> >                       bdsHeight = ifHeight / bdsSF;
> >                       if (std::fmod(bdsHeight, 1.0) == 0) {
> > @@ -151,7 +152,8 @@ void calculateBDSHeight(ImgUDevice::Pipe *pipe,
> const Size &iif, const Size &gdc
> >               }
> >
> >               ifHeight = utils::alignUp(estIFHeight, IF_ALIGN_H);
> > -             while (ifHeight <= iif.height && ifHeight / bdsSF >=
> minBDSHeight) {
> > +             while (ifHeight >= minIFHeight && ifHeight <= iif.height &&
> > +                    ifHeight / bdsSF >= minBDSHeight) {
> >
> >                       bdsHeight = ifHeight / bdsSF;
> >                       if (std::fmod(bdsHeight, 1.0) == 0) {
> > --
> > 2.31.1
> >
> > _______________________________________________
> > libcamera-devel mailing list
> > libcamera-devel at lists.libcamera.org
> > https://lists.libcamera.org/listinfo/libcamera-devel
>
> --
> Regards,
> Niklas Söderlund
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20210506/dd44af19/attachment.htm>