[libcamera-devel] [PATCH 2/2] ipa: ipu3: Set output frame duration metadata

[Hirokazu Honda]

Hi Paul, thank you for the patch.

On Sun, May 23, 2021 at 9:17 AM Laurent Pinchart <
laurent.pinchart at ideasonboard.com> wrote:

> On Fri, May 21, 2021 at 01:55:14PM +0200, Jacopo Mondi wrote:
> > On Fri, May 21, 2021 at 07:55:34PM +0900, Paul Elder wrote:
> > > The sensor frame duration should be set by the IPA. Hardcode it for
> now.
> > >
> > > Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
> >
> > With a \todo
> >
> > Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>
>
> Ditto, the todo is important.
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
>
>
Reviewed-by: Hirokazu Honda <hiroh at chromium.org>


> > > ---
> > >  src/ipa/ipu3/ipu3.cpp | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > >
> > > diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp
> > > index f5343547..35c24052 100644
> > > --- a/src/ipa/ipu3/ipu3.cpp
> > > +++ b/src/ipa/ipu3/ipu3.cpp
> > > @@ -269,6 +269,10 @@ void IPAIPU3::parseStatistics(unsigned int frame,
> > >     if (agcAlgo_->updateControls())
> > >             setControls(frame);
> > >
> > > +   ctrls.set(controls::FrameDurations,
> > > +             { static_cast<int64_t>(33334),
> > > +               static_cast<int64_t>(33334) });
> > > +
> > >     IPU3Action op;
> > >     op.op = ActionMetadataReady;
> > >     op.controls = ctrls;
>
> --
> Regards,
>
> Laurent Pinchart
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20210524/50ef9324/attachment.htm>