[libcamera-devel] [PATCH v2 1/2] pipeline: ipu3: Fix mis-aligned comment

Laurent Pinchart laurent.pinchart at ideasonboard.com
Wed May 26 15:40:02 CEST 2021


Hi Umang,

Thank you for the patch.

On Wed, May 26, 2021 at 06:40:24PM +0530, Umang Jain wrote:
> Fixes: 2fac95b400b7 ("libcamera: pipeline: ipu3: Ensure that IPU3Frames::info is not used after delete")
> Signed-off-by: Umang Jain <umang.jain at ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/libcamera/pipeline/ipu3/ipu3.cpp | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp
> index 25203256..750880ed 100644
> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp
> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp
> @@ -1361,9 +1361,9 @@ void IPU3CameraData::statBufferReady(FrameBuffer *buffer)
>  		info->metadataProcessed = true;
>  
>  		/*
> -		* tryComplete() will delete info if it completes the IPU3Frame.
> -		* In that event, we must have obtained the Request before hand.
> -		*/
> +		 * tryComplete() will delete info if it completes the IPU3Frame.
> +		 * In that event, we must have obtained the Request before hand.
> +		 */
>  		Request *request = info->request;
>  
>  		if (frameInfos_.tryComplete(info))

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list